-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: CLIEngine#getRules() (refs #6582) #9782
Conversation
5b2e820
to
783cc97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for contributing!
Would it be possible to add a method on the exported plugin object that generates the docs URL so that people can optionally DRY out their code? (i.e. |
That could be interesting/valuable, but this PR probably isn't the place to
discuss :-)
…On Dec 28, 2017 11:25 AM, "Jed Fox" ***@***.***> wrote:
Would it be possible to add a method on the exported plugin object that
generates the docs URL so that people can optionally DRY out their code?
(i.e. getDocsURL: name => `https://github.com/foo/
eslint-plugin-bar/blob/master/docs/rules/${name}.md`
<https://github.com/foo/eslint-plugin-bar/blob/master/docs/rules/$%7Bname%7D.md>
instead of providing meta.docs.url on each rule)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9782 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AARWenHw8utTXlFhW-6gXs_IpfKWUDTKks5tE875gaJpZM4ROYPV>
.
|
Also it already can be done by extracting the logic into a separate file, and importing it into each rule in the plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind rebasing on master and adding this new function to the table of contents added in #9785? Thanks!
783cc97
to
c32d636
Compare
@platinumazure Done. Thanks for merging #9785! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[x] Add a CLI
optionmethod[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
Next step::
meta.docs.url
to each of the built-in rulesmeta.docs.url
as a property that third party rules are encouraged to include